suxiaogang223 opened a new pull request, #69684:
URL: https://github.com/apache/doris/pull/69684
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: A Hive catalog already exposes `information_schema.tables`
and `information_schema.columns`, and ordinary Hive column comments already
flow from HMS. However, `HiveConnectorMetadata.getTableComment()` only read HMS
`parameters["comment"]` for Iceberg-on-HMS tables. It returned an empty string
for ordinary Hive tables even when HMS stored a table comment. Read that
existing HMS parameter for every table format, preserving the empty result for
absent comments or unreadable tables. This adds no metadata RPC, network
destination, or new privilege path.
### Release note
Hive catalog `information_schema.tables.TABLE_COMMENT` and `SHOW TABLE
STATUS` now display table comments stored in HMS.
### Check List (For Author)
- Test: Unit Test
- `./run-fe-ut.sh --run
'org.apache.doris.connector.hive.HiveConnectorMetadataTableCommentTest,org.apache.doris.connector.hive.HiveConnectorMetadataSchemaTest'`:
31 passed; FE reactor build succeeded.
- `mvn -f fe/pom.xml -pl fe-connector/fe-connector-hive checkstyle:check
-DskipTests -q`: passed.
- `build-support/check-fe-connector-imports.sh` and `git diff --check`:
passed.
- `./build.sh --fe` could not start on this machine because LLVM 20 is
not installed. External cluster regression was not run locally.
- Behavior changed: Yes. Plain Hive table comments now appear in table
metadata views.
- Does this need documentation: No
### Self-review
- Scope: Only the Hive connector's table comment lookup changes. Existing
column comment propagation remains intact and is covered by a schema unit test,
including partition columns.
- Compatibility: Iceberg-on-HMS comments and empty or unreadable table
behavior retain their existing tests. No SPI, Thrift, persistence, or catalog
property changes.
- Metadata lifecycle: The lookup uses the existing cached HMS table, so
comment changes follow the existing table metadata refresh path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
