924060929 commented on code in PR #69683:
URL: https://github.com/apache/doris/pull/69683#discussion_r4387233383
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/split/SplitSource.java:
##########
@@ -147,10 +121,10 @@ public synchronized List<TScanRangeLocations>
getNextBatch(int maxBatchSize) thr
throw new UserException("Timeout. Max wait time(ms): " +
maxWaitTime);
}
try {
- batch = splitAssignment.awaitBatch(backend, remainingNanos);
- if (batch != null) {
+ TScanRangeLocations split =
splitAssignment.awaitSplit(backend, remainingNanos);
+ if (split != null) {
splitAssignment.notifyQueueSpace(backend);
- pendingSplits = batch.iterator();
+ scanRanges.add(split);
Review Comment:
Fixed in 1145d3da7be. After an awaited split wakes and notifies queue-space
listeners, the fetch now rechecks the assignment error and stop state before
adding that split to the response. A deterministic one-split race test
reproduced the old incorrect OK result for both producer failure and
cancellation; both now pass. The complete SplitSourceTest class (33 tests) also
passes via the existing Surefire classpath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
