csun5285 opened a new pull request, #69696:
URL: https://github.com/apache/doris/pull/69696

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #65396
   
   Problem Summary: Ordered reads of nested struct fields over a rowset with 
multiple overlapping segments use pruned sub-column iterators, but the merge 
reader creates its intermediate blocks from the full physical schema. The 
mismatched child layouts can decode strings into numeric columns, return the 
wrong fields, or crash the BE. Backport the merge-block portion of #65396 to 
branch-4.2: use the FE-pruned type by column unique ID when constructing merge 
blocks, retaining the physical type for unpruned columns. Include focused unit 
and regression coverage for block reuse and nested field reads.
   
   ### Release note
   
   Fix errors and BE crashes when ordered scans read pruned complex columns 
across overlapping segments.
   
   ### Check List (For Author)
   
   - Test:
       - ASAN BE build and FE build.
       - Unit test: VGenericIteratorsTest.*, all 7 tests passed.
       - Regression test: 
fault_injection_p0/test_topn_pruned_struct_overlapping_segments. The original 
merge-block construction reproduced E-3110 for TINYINT; the same suite passed 
all 4 queries after restoring the fix.
       - Regenerated the expected output with the regression script; it matches 
the original PR's corresponding generated output byte for byte.
       - clang-format 16 passed. clang-tidy found no diagnostics on changed 
lines; its full run is blocked by an existing unmatched NOLINTEND in 
core/types.h.
   - Behavior changed: Yes. Merge blocks use the requested pruned complex types.
   - Does this need documentation: No
   
   Partial backport of 3c43f4cd96d8041713391701fe6746c40fba6708 (merge blocks).
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to