924060929 commented on code in PR #69683:
URL: https://github.com/apache/doris/pull/69683#discussion_r4396357189
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -1119,6 +1119,10 @@ public TFetchSplitBatchResult
fetchSplitBatch(TFetchSplitBatchRequest request) t
result.setSplits(locations);
result.status = new TStatus(TStatusCode.OK);
return result;
+ } catch (SplitSource.SplitPendingException e) {
+ // The backend will retry; an empty OK batch would incorrectly
mean EOF.
+ result.status = new TStatus(TStatusCode.INCOMPLETE);
Review Comment:
This PR targets master only, with no release-branch backport. Doris upgrades
BE before FE, so an FE containing this change is deployed only after the BE
that understands the INCOMPLETE retry response. Upgrading FE first against a
pre-change BE is outside the supported order for this master-only change; there
is no intermediate master release to support. I am keeping this PR focused and
am not adding capability negotiation for that unsupported pairing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
