morningman commented on PR #69711: URL: https://github.com/apache/doris/pull/69711#issuecomment-6463293409
Addressed the first review round in `3e250364574`. Per finding: - 4395446119 (P2, INT96 data keys against TIMESTAMPTZ tombstones): fixed. When the table field is timestamptz, a `DATETIMEV2` / `TIMESTAMPTZ` pair compares as `TIMESTAMPTZ` at the larger scale, the `DATETIMEV2` side converted with the session time zone as the projection converts that column. The failure was not limited to id-only queries, see the thread. - 4395446127 (P2, NULL leaf under a struct default): fixed. The default is walked down the key's path, and a NULL leaf is compared in the delete file's type. The current FE cannot produce this history (Iceberg 1.12 rejects a non-null default on a nested type), so it is covered by a unit test. - 4395446137 (P2, empty delete files and strict key casts): fixed. A filter whose delete block has no rows is skipped before its keys are resolved. The evaluation order predates this PR: on master a `TIMESTAMP_NS` table key already failed this way. BE unit tests on macOS arm64 (ASAN), `IcebergV2ReaderTest.*:*EqualityDelete*:*ColumnMapper*:*EvolutionCast*:*TableReader*`: 524 of 524 pass, including the three new cases; removing each fix fails its new test. clang-tidy passes on the changed lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
