morningman commented on PR #69749: URL: https://github.com/apache/doris/pull/69749#issuecomment-6470825948
Addressed the first review round in 4ed5856f57c. - 4399202162 (metadata load): fixed. The replay path adopts the workload group name without resolving it, as it already did for the compute group. This also covers an older failure on master: image load re-parses routine load jobs before the workload groups module is loaded, so a job created with `workload_group` was cancelled by the first restart that loaded it from an image. - 4399202170 (suspended declared group): fixed for CREATE and ALTER, which now start the declared group the way `USE @<group>` does before their Kafka metadata requests; the scheduler half is master's existing behavior for every cloud routine load job and is unchanged. - 4399202175 (combined ALTER): fixed; the offset conversion uses the group the ALTER declares. - 4399202181 (hint in the MV query) and 4399202183 (two reads): not changed, see the replies; both match master's existing behavior or branch-4.x. RoutineLoadComputeGroupTest gains five tests, each red without its fix; 24 related FE test classes, 398 tests, pass with Checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
