Gabriel39 commented on PR #69672: URL: https://github.com/apache/doris/pull/69672#issuecomment-6465450540
Rechecked all 18 inline review threads and the latest review summaries. All nine outstanding findings are addressed in b2f7d3fbbcfc9006aa7004306fd0011379b7897e, with individual replies and resolutions. The update covers alias/script fields absent from source, ARRAY nullness, default-date timezone differences, disabled source and populated disabled roots, Boolean empty strings, exact integer coercion/singleton arrays, legacy runtime mapping types, and retained negation NULL semantics. Both readers share the corrected decoder/request builder. Pure docvalue controls remain covered; source fallbacks and full-source requests have their cost tradeoffs documented in the updated PR description. Validation: 158 FE ES tests passed, one optional ES9 class skipped; all 12 BE unit tests passed. Four live ES8 suites passed 1,452 stored checks, 1,356 independent comparisons and 88 expected planning-error checks. The final new fixture passed a separate non-generation rerun; all 1,148 existing stored results remain unchanged. Standard ASAN BE build, FE Checkstyle, clang-format 16, scoped clang-tidy and build hygiene passed. Posted run buildall and /review in the required order after pushing the new commit. Those CI/review runs are pending; the results above are local validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
