morningman commented on PR #69771: URL: https://github.com/apache/doris/pull/69771#issuecomment-6483470866
Addressed the first review round in 3b3f2a6dec6 and 3489284b381. Per finding: - P1, failed `_query_plan` scans ended as complete results (r4400505759): fixed in 3b3f2a6dec6. This predates the PR: nothing has written the result queue's status since the non-pipeline engine was removed (#35803), so any failure on that path ended the read at the rows fetched so far. The sink now records a failed execution status before the end-of-scan sentinel, and `fetch_result` checks the status again when it takes the sentinel. The new regression `test_query_plan_scan_validation` reads `_query_plan` scans through `open_scanner` / `get_next`: on the previous head the invalid UTF-8 scan read 0 rows without an error; now it gets the error. - P2, pytz's minute-rounded offsets at the zoned lower bound (r4400505772): fixed in 3489284b381. The zoned bounds also hold with pytz's rounded offsets; America/Chicago's lower bound moves from 05:50:36Z to 05:51:00Z, covered by a new BE UT. The description now covers both changes, including the behavior change for `_query_plan` readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
