morningman commented on PR #69749: URL: https://github.com/apache/doris/pull/69749#issuecomment-6485878687
Addressed the second review round in 7611a91f1d5 and 45cda592e43. - 4401555635 (SHOW CREATE ROUTINE LOAD): fixed in 7611a91f1d5. The statement writes the declared `compute_group` only when one is declared, and never the effective group, so a job without a declaration prints what it did before. The other properties CREATE accepts that the statement leaves out predate this PR and are left to a separate change. - 4401555648 (IVM dry run): fixed in 45cda592e43. `REFRESH ... WITH DRY RUN` binds the MV's declared group to its context and re-checks it, as a refresh does, and `EXPLAIN REFRESH` binds it to its planning context; an MV without a declaration resolves as before. From the summary (item 10), `test_mtmv_compute_group` is hardened in 45cda592e43: it inserts a row before the refresh that follows the same-value ALTER and checks the task that refresh created, found by id. Before, that refresh was NOT_REFRESH, which records no compute group, and the check read the first row of an unordered tasks() result. RoutineLoadJobTest gains one test and RefreshMTMVCommandTest four. The SHOW CREATE test and three of the four (the binding of each context, the dry run's re-check) are each red without their fix; the fourth covers an MV without a declaration. 29 related FE test classes, 558 tests, pass with Checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
