siddiqueirshad commented on PR #69786: URL: https://github.com/apache/doris/pull/69786#issuecomment-6487788840
Hi @hello-stephen, Here are the detailed responses according to the template: 1. **Problem Fixed**: In cloud mode, FE \CloudInternalCatalog\ formatted initial rowset IDs with uppercase hex (\%016X\). BE \ rom_hex\ in \e/src/util/uid_util.h\ only handled lowercase \'a'-'f'\ and digits. For uppercase \'A'-'F'\, \(i - 'a' + 10)\ calculated a negative offset (-22 to -17), corrupting the parsed rowset ID when bitwise-ORed into \ al\. 2. **Behavior Modified**: \ rom_hex\ now checks \'A' <= i && i <= 'F'\ with \i - 'A' + 10\, correctly parsing hex strings regardless of case. In addition, FE's \CloudInternalCatalog\ now formats with \%016x\ (lowercase hex) for consistency with BE rowset ID conventions. 3. **Features Added**: Case-insensitive hex parsing for UID/rowset ID parsing. 4. **Code Refactored**: Minimal targeted fix to the character branch in \uid_util.h\ and format specifier in \CloudInternalCatalog.java\. 5. **Optimization/Verification**: Completely avoids ID corruption and invalid rowset errors in cloud mode. Verified with new test \UidUtilTest.FromHexCaseInsensitive\ in \e/test/util/uid_util_test.cpp\. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
