bobhan1 commented on PR #67292: URL: https://github.com/apache/doris/pull/67292#issuecomment-6488366937
/review Please focus on re-evaluating the existing P1 finding: https://github.com/apache/doris/pull/67292#discussion_r4344901080. The current head is `cd83598180604dc8d8b5908bcba0ae3e685116ce`. Commit `cd83598180604dc8d8b5908bcba0ae3e685116ce` adds a validator for `s3_write_buffer_size` and the `S3WriteBufferConfigTest.ValidateRuntimeUpdates` unit test. With File Cache enabled, the validator rejects upload buffer sizes that are smaller than a cache block or are not exact multiples of the cache block size. Please evaluate the finding against the current code, considering both the startup alignment check in `ExecEnv::init_file_cache_factory()` and runtime validation in `config::set_config()`. If the P1 still applies, provide a concrete reachable scenario, including the configuration, complete call chain, and cache-block creation or restoration steps, and explain why the new validator does not prevent it. Distinguish newly written cache blocks from historical cache blocks restored after an upgrade, and consider configuration-update visibility where relevant. If the original finding no longer applies, explicitly update its disposition in this review. Please base the conclusion on the current implementation rather than carrying forward the previous verdict without explaining its applicability after the fix. This focus is additional to the normal full-PR review and does not presume a passing result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
