github-actions[bot] commented on code in PR #69804:
URL: https://github.com/apache/doris/pull/69804#discussion_r4408907717
##########
be/src/exec/scan/file_scanner_v2.cpp:
##########
@@ -777,6 +778,7 @@ Status FileScannerV2::_init_table_reader(const
TFileRangeDesc& range) {
.io_ctx = _io_ctx,
.runtime_state = _state,
.scanner_profile = _local_state != nullptr ?
_local_state->scanner_profile() : _profile,
Review Comment:
[P2] Forward the profile cache through LoadTableReader
FileScannerV2 now passes the scan-owned `ParquetProfileCache` into the
selected `TableReader`, but Parquet-backed load scans select `LoadTableReader`
and its `init()` rebuilds the delegated `TableReadOptions` without copying
`options.parquet_profile_cache`
(`be/src/format_v2/table/load_reader.cpp:84-93`). The delegated base reader
consequently constructs each Parquet file with a null cache, so
`_init_profile()` re-registers the full counter set under
`RuntimeProfile::_counter_map_lock` for every load file. Please forward the
field in that delegation and add multi-file Parquet load coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
