github-actions[bot] commented on code in PR #69856:
URL: https://github.com/apache/doris/pull/69856#discussion_r4416008492
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/mtmv/MTMVTask.java:
##########
@@ -1349,6 +1423,8 @@ private void
executePartitionBasedRefresh(MTMVRefreshContext context, RefreshMod
mtmv.getName(), getTaskId(), e);
throw new JobException(e.getMessage(), e);
}
+ recordCommitted(refreshMode == RefreshMode.COMPLETE
+ ? IvmRefreshMethod.COMPLETE :
IvmRefreshMethod.PARTITION_REBUILD);
Review Comment:
[P1] Make cancellation publish the IVM report only after the worker is
quiescent. `cancel(false)` reaches `after()` without waiting; `after()`
computes `ivmRefreshMethod` and records metrics/journals the task, but an
in-flight incremental refresh can return successfully after cancellation and
then call `recordCommitted`, which only updates the transient set and never
revises the published method or counters. A STOP can therefore leave the MV
with committed incremental or partition data while `tasks()` and the persisted
summary say `NONE` (and miss the fallback). Use one quiescent or atomic
terminal snapshot for cancellation, metrics, and journaling so late commits
cannot escape the report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
