github-actions[bot] commented on code in PR #69852: URL: https://github.com/apache/doris/pull/69852#discussion_r4416183888
########## fe/fe-core/src/main/java/org/apache/doris/tablefunction/VectorSearchTableValuedFunction.java: ########## @@ -23,6 +23,7 @@ import org.apache.doris.thrift.TExternalSearchQuery; import org.apache.doris.thrift.TExternalSearchRequest; import org.apache.doris.thrift.TSearchVector; +import org.apache.doris.thrift.TVectorApproxMode; import org.apache.doris.thrift.TVectorElementType; Review Comment: [P1] Gate approx_mode across smooth upgrades. An older BE silently skips new optional Thrift field 6, so approx_mode=fast or accurate can run some splits with Lance NORMAL while new BEs honor the requested mode. LanceScanNode only rejects smooth-upgrade BEs for new Lance type readers, leaving ordinary vector searches eligible; the global TopN then merges candidates from different approximation policies and can return different recall/order than requested. Reject explicit non-default modes while any selected BE is a smooth-upgrade source, or add a capability gate that keeps all splits on mode-aware BEs and reports the effective mode in EXPLAIN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
