morningman commented on PR #69749: URL: https://github.com/apache/doris/pull/69749#issuecomment-6513661357
Addressed review round 5 in `c9d9730047e`. - 4415694066: an ALTER that sets `compute_group` checks the job's workload group in that group, as CREATE does, and is rejected if the group does not have it. An ALTER that sets `workload_group` alone is still not checked, as on master. - 4415694077: an auto resume attempt leaves the compute group check to the check before the first task, which records a revoked USAGE as CANNOT_RESUME_ERR. The refresh check added in round 3 had swallowed it for a job that was still PAUSED. - 4415694090: each MV refresh context reads the declared compute group once and binds, records and re-checks that value. RoutineLoadComputeGroupTest gains two tests and MTMVComputeGroupTest one, each red without its fix; 17 related FE test classes, 244 tests, pass with Checkstyle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
