suxiaogang223 commented on PR #69886: URL: https://github.com/apache/doris/pull/69886#issuecomment-6517964964
/review Please review the full branch-4.2 Paimon Rust append MVP. Pay particular attention to fixed memory credit and admission-slot release on all failure paths, Arrow ownership across Rust worker threads, awaited native shutdown, cleanup of partial/prepared files, Java v11 commit-message compatibility, and fallback selection before input consumption. The intended MVP explicitly accepts fixed estimated memory credit rather than complete Rust allocator/RSS accounting, no spill/revoke/live budget resizing, and cancellation only between native calls. Please evaluate correctness within these stated constraints. The writer is opt-in and defaults to JNI. Supported Rust writes are unpartitioned append-only, main branch, bucket=-1, Parquet, and supported scalar columns. Validation already completed: 10 new BE tests under ASAN plus five shuffled rounds (50/50), 23 focused FE tests, 3 focused Rust tests, full BE/FE builds, and a MinIO/Doris/Spark SQL regression. The BE tests include exhaustion/cancellation after a file was rolled, prepared-file abort, failed-open cleanup, admission reuse, and query-credit restoration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
