github-actions[bot] commented on code in PR #69851:
URL: https://github.com/apache/doris/pull/69851#discussion_r4422444601


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/IvmFullRefreshMTMV.java:
##########
@@ -86,7 +86,12 @@ private Plan rewriteScan(LogicalOlapScan scan, 
IvmRewriteContext rewriteContext)
         Optional<Set<Long>> resetPartitionIds =
                 rewriteContext.getFullRefreshResetPartitionIds(baseTableInfo);
         StreamReadMode readMode;
-        if (resetPartitionIds.isPresent()) {
+        if (rewriteContext.isExplain() || resetPartitionIds.isPresent()) {

Review Comment:
   [P2] Keep COMPLETE EXPLAIN usable when refresh can reconcile its stream. 
With `fullExplain()` now enabling this branch, `IvmUtil.getIvmStream` throws 
for a missing, disabled, or stale stream. A real IVM COMPLETE attempt first 
calls `MTMVTask.reconcileIvmStreams()`, whose 
`CreateMTMVCommand.createTableStream()` path creates or recreates that stream 
before planning, so the refresh succeeds while EXPLAIN fails. Please avoid 
treating this recoverable state as an EXPLAIN error (or otherwise mirror the 
reconciliation result) so EXPLAIN remains usable for the same COMPLETE 
operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to