github-actions[bot] commented on code in PR #69896:
URL: https://github.com/apache/doris/pull/69896#discussion_r4422920705
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/analysis/AnalysisManager.java:
##########
@@ -28,6 +28,7 @@
import org.apache.doris.catalog.ScalarType;
import org.apache.doris.catalog.Table;
import org.apache.doris.catalog.TableIf;
+import org.apache.doris.catalog.TabletMeta;
Review Comment:
[P2] Place TabletMeta after Tablet to pass FE Checkstyle
The new import precedes Tablet, but fe/check/checkstyle/checkstyle.xml
enables alphabetical CustomImportOrder at error severity. fe/pom.xml binds the
failing check to validate, and the FE Checkstyle workflow also runs it, with no
applicable suppression. Move TabletMeta below Tablet so the required validation
gate accepts this change.
##########
be/src/storage/task/engine_publish_version_task.cpp:
##########
@@ -243,8 +243,14 @@ Status EnginePublishVersionTask::execute() {
auto rowset_meta_ptr = rowset->rowset_meta();
auto tablet_id = rowset_meta_ptr->tablet_id();
- if (_publish_version_req.base_tablet_ids.contains(tablet_id)) {
+ if (_publish_version_req.base_tablet_ids.contains(tablet_id)
+ || tablet->is_changelog_tablet()) {
Review Comment:
[P2] Report the attached changelog rowset for grouped loads
Normal changelog loads commit only the base rowset into TxnManager:
GroupRowsetBuilder::commit_txn stores the companion in
txn_info_it->second->attach_changelog.rowset, and
ChangelogRowsetBuilder::commit_txn only marks it committed.
get_txn_related_tablets therefore exposes the base tablet to this loop, so the
new is_changelog_tablet() branch never inserts the companion tablet ID or its
rows. Those loads leave the new FE changelog counter at zero. Report the
attached rowset under its own tablet ID after publish workers finish (MoW
publication can append changelog segments), and cover the emitted report map in
a publish-path test; the added direct-accumulator test cannot detect this
omission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
