github-actions[bot] commented on code in PR #69836:
URL: https://github.com/apache/doris/pull/69836#discussion_r4421581161
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/mvcc/PluginDrivenMvccExternalTable.java:
##########
@@ -522,6 +522,12 @@ private MvccSnapshot loadSnapshotInternal(
Optional<TableSnapshot> tableSnapshot,
Optional<TableScanParams> scanParams,
Optional<MvccSnapshot> latestSnapshotFence) {
+ // Views have no table snapshot. BindRelation expands their SQL and
pins the base tables;
+ // resolving a table handle here would load the view name through the
table API.
+ if (isView()) {
Review Comment:
[P1] Preserve or reject view @branch/@tag selectors: `BindRelation` calls
`loadSnapshots` before expanding a plugin view, and its view guard rejects only
`TableSnapshot`. With this early return, Iceberg `@branch`/`@tag` never reaches
`resolveTimeTravel`, and the returned `LogicalSubQueryAlias` carries no
selector, so `SELECT ... FROM view@branch('b')` silently reads the
default/latest view body. Reject these selectors for views (as for `FOR
VERSION/TIME`) or propagate them to the expanded base relations; do not drop
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
