github-actions[bot] commented on code in PR #69837:
URL: https://github.com/apache/doris/pull/69837#discussion_r4429901107
##########
fe/fe-core/src/main/java/org/apache/doris/metric/PrometheusMetricVisitor.java:
##########
@@ -164,7 +164,7 @@ public void visit(String prefix,
@SuppressWarnings("rawtypes") Metric metric) {
List<MetricLabel> labels = metric.getLabels();
if (!labels.isEmpty()) {
sb.append("{");
- List<String> labelStrs = labels.stream().map(l -> l.getKey() +
"=\"" + l.getValue()
Review Comment:
[P1] Null source cluster in legacy table warm-up metrics crashes /metrics
Table warm-up jobs use a constructor that sets `srcClusterName` to null.
When such a job is cancelled or times out,
`updateClusterWarmUpJobLastFinishTime` registers `src_cluster_name=null`. The
new `visit()` call invokes `escapeLabelValue(null)`, whose `value.replace(...)`
throws; `MetricRepo.getMetric` and `MetricsAction` do not catch it, so the
entire public `/metrics` response fails after a normal table-job cancellation.
Please preserve the old null rendering or normalize nullable label values
before escaping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
