morningman commented on PR #69867: URL: https://github.com/apache/doris/pull/69867#issuecomment-6539895107
Addressed review round 2 in `36772dcc027`. - 4420363330: an untyped NULL result column now keeps the placeholder schema, at any depth (ARRAY, MAP, STRUCT). BE builds such a column as a `UInt8` flagged as a NULL literal and sends it as nullable `Bool`, so the advertised `Null` made every prepared execution fail with "Prepared statement schema changed", which is how `query_p0/operator/test_sort_operator` (`select org_id,null from dim_org ...`) failed in P0. Its executions are no longer checked, and GetSchema answers UNIMPLEMENTED, as on master today. A typed NULL is still described as its type. New and changed tests, each red without the fix: - `DorisFlightSqlSchemaTest` adds `untypedNullResultsKeepThePlaceholder` (top-level and nested NULL; the placeholder assertions of `commandsWithUnknownOrDynamicMetadataKeepThePlaceholder` move into a shared helper). - `test_schema_only` adds `SELECT NULL` and `SELECT ARRAY(NULL)` to the placeholder statements and runs a prepared `SELECT k, NULL AS n ...` twice through the backends. Against the previous head it fails at `SELECT NULL AS n`. 41 related FE test classes, 537 tests, pass with Checkstyle. On a local cluster, all `arrow_flight_sql_p0` suites and `test_uuid_arrow_flight` pass, and `test_sort_operator` over Flight SQL fails on the previous head and passes on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
