morningman commented on PR #69581: URL: https://github.com/apache/doris/pull/69581#issuecomment-6539887653
Rebased onto master 339e087b11f. The only conflict was the reach budget table again: #67292 moved the `util/rle_encoding.h` baseline from 828 to 834. Master alone reaches 917 (limit 918) and this PR reaches 921, so the rebaseline commit now sets 921, and its message and the description carry the new numbers. #69872 added Arrow type checks to the map and struct readers ahead of this PR's NULL-parent masking; they merged without conflict. `check-build-hygiene.sh` passes. Of the 114 sources that this PR changes or that master changed since 8d88f1cc6f7, 111 pass a syntax check against the rebased tree. The other three are master's: two new #67292 files under `storage/segment` fail the same way on master alone outside their unity batch (this PR adds no source to that target), and the #69818 benchmark is not in the UT build and includes only `util/simd` headers that this PR does not touch. Addressed in 3c278213385, on top of the rebase: - 4410247535 (P2, INT64_MIN runtime filter literal): fixed. Integer literals and scale-zero decimal literals now go through `parse_lance_int64_literal()`, which parses them as the pinned Lance parser does and rejects INT64_MIN, so an IN, `>=` or `<=` runtime filter that mentions it stays residual-only instead of failing Lance planning; INT64_MIN + 1 and every other i64 are still pushed. New tests: `LanceRuntimeFilterHelperTest.KeepsInt64MinFiltersResidualOnly` (ordinary, not null-aware, filters on INT64_MIN are skipped and the same filters on INT64_MIN + 1 are pushed with the expected SQL) and `LanceTableReaderFilterTest.KeepsInt64MinRuntimeFiltersOutOfLanceScanner` (a Lance dataset holding INT64_MIN is read under an INT64 IN, an INT64 `<=` and a DECIMAL(38, 0) IN on it). All 106 Lance cases (`Lance*`) pass under ASAN on macOS arm64; restoring `parse_int64()` in either check makes exactly the two new tests fail, the reader case with Lance's "Received literal Float64(...) and could not convert" planning error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
