OIiveirra commented on code in PR #69032:
URL: https://github.com/apache/doris/pull/69032#discussion_r4430880768


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Ndv.java:
##########
@@ -63,6 +63,10 @@ private Ndv(AggregateFunctionParams functionParams) {
 
     @Override
     public void checkLegalityBeforeTypeCoercion() {
+        // The BE kernel has no spatial value-state dispatch; fail before 
casts hide the input type.
+        if (getArgumentType(0).isSpatialType()) {

Review Comment:
   The existing isOnlyMetricType() check already rejects Array/Map/Struct 
before coercion, including the state entry points. Added actual 
analyze/rewrite, declared-state and Iceberg scan regressions confirming 
rejection. NDV production code is unchanged.
   
   Commit: 
[ec7c88263491](https://github.com/apache/doris/commit/ec7c88263491d67470584e7e361330567c730b65).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to