github-actions[bot] commented on code in PR #17011:
URL: https://github.com/apache/doris/pull/17011#discussion_r1113780938


##########
be/src/olap/lru_cache.h:
##########
@@ -406,7 +406,7 @@ class ShardedLRUCache : public Cache {
     Slice value_slice(Handle* handle) override;
     virtual uint64_t new_id() override;
     virtual int64_t prune() override;
-    virtual int64_t prune_if(CacheValuePredicate pred) override;
+    virtual int64_t prune_if(CacheValuePredicate pred, bool lazy_mode = false) 
override;

Review Comment:
   warning: 'virtual' is redundant since the function is already declared 
'override' [modernize-use-override]
   
   ```suggestion
   ;
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to