github-actions[bot] commented on code in PR #69806:
URL: https://github.com/apache/doris/pull/69806#discussion_r4439914515
##########
fe/fe-connector/fe-connector-hms/src/main/java/org/apache/doris/connector/hms/ThriftHmsClient.java:
##########
@@ -180,8 +182,12 @@ public boolean tableExists(String dbName, String
tableName) {
@Override
public HmsTableInfo getTable(String dbName, String tableName) {
return execute(client -> {
- Table table = client.getTable(dbName, tableName);
- return convertTable(table);
+ try {
+ return convertTable(client.getTable(dbName, tableName));
+ } catch (NoSuchObjectException | UnknownTableException failure) {
Review Comment:
[P2] Preserve table absence from Hive partition-name reads
With a warm partitioned Hive table in `CachingHmsClient`, drop the table
remotely and run `SHOW PARTITIONS` or `PARTITIONS` before the table-cache entry
expires. Cached handle resolution still succeeds, but `listPartitionNamesFresh`
then executes Hive's native RPC, which reports table absence ([Hive 3.1.3
source](https://github.com/apache/hive/blob/rel/release-3.1.3/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L4422-L4426)).
Only `getTable` creates the typed exception here; both
`ThriftHmsClient.listPartitionNames` overloads leave a raw
`NoSuchObjectException` inside `HmsClientException`. The new FE `MetadataRead`
requires `ConnectorTableNotFoundException`, so the failed listing leaves stale
names, table object, numeric route and connector caches resident. Normalize
definite table absence at those listing boundaries and cover native
adapter-to-FE propagation. This is Hive's separate RPC, distinct from the
earlier Iceberg partition-name fin
ding; the new FE tests inject an already-typed error and miss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
