raghav-reglobe commented on PR #66115:
URL: https://github.com/apache/doris/pull/66115#issuecomment-6581323888
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#66115
commit: 0f8b49234ac73237d2e58473550efa35871c85e7
base: 886cb3ea48d7cf6cd3344edce0b1422ec5700634
reviewed_at: 2026-11-02T21:11+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 1, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/UserManager.java:510`
— the one Minor: `DISCARD OLD PASSWORD` on a domain account (`u@['d']`) swaps
the domain entry only and does not call `refreshAuthenticationBinding`, so the
resolver-materialised IP entries keep the discarded secondary until the next
DomainResolver pass (≤ 10 s on every FE); `SET PASSWORD`, LOCK/UNLOCK and
REQUIRE refresh at once, so the javadoc's "same lag as a plain password change"
is not accurate. One-line fix inside the existing write lock plus a unit test;
details in the local review documents.
- Not verified locally: no build, unit or regression run — the review is
static over the authoritative diff, the pinned gson 2.10.1 jar and the MySQL
8.0 dual-password reference.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
