raghav-reglobe commented on PR #68745:
URL: https://github.com/apache/doris/pull/68745#issuecomment-6582353666
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68745
commit: 5e7eddf5a323378d4fcc857e05e05728f4a00ba5
base: 7ac0eb2fdb426595f810e94ab77b7aa2eece12d5
reviewed_at: 2026-11-02T21:56+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 5}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/test/java/org/apache/doris/mysql/MysqlChannelCompressionTest.java:427`
— the compressed write→read-several→write turn (the LOAD DATA LOCAL INFILE and
COM_CHANGE_USER shape, where the FE's reply is numbered from frames it both
sent and read) has no unit case and the suite issues no LOAD DATA; the
invariant holds at this head (re-derived against net_serv.cc and Connector/J
8.0.28) but is unpinned. The five Nits are test pins and a stale PR body;
details in the local review documents.
- Not verified locally: no build, unit or regression run; evidence is the
diff, the Connector/J 8.0.28 sources jar, mysql-server 8.0 net_serv.cc /
my_compress.cc, zlib 1.3.1 inflate.c and the OpenJDK 17 Inflater/Deflater
natives. The real-cipher compressed-over-TLS path is exercised only by the
suite's default round on CI.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
