github-actions[bot] commented on code in PR #69991:
URL: https://github.com/apache/doris/pull/69991#discussion_r4445270906
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/source/HiveScanNode.java:
##########
@@ -256,7 +261,7 @@ public void startSplit(int numBackends) {
try {
List<Split> allFiles = Lists.newArrayList();
getFileSplitByPartitions(
- cache,
Collections.singletonList(partition), allFiles, bindBrokerName,
Review Comment:
[P2] Preserve Hive's per-partition approximate split estimate when batching
partitions. `getFileSplitByPartitions()` now receives the whole `partitions`
batch, so `allFiles.size()` at this line is the total for (up to) 16
partitions. The unchanged `numApproximateSplits()` multiplies that value by
`prunedPartitions.size()` again; six ten-file partitions therefore report 360
instead of the regression's expected 60 and inflate `totalFileSize`/split
estimates. Track the per-partition maximum (or normalize the batch total)
before multiplying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
