raghav-reglobe commented on PR #68527:
URL: https://github.com/apache/doris/pull/68527#issuecomment-6583475811
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#68527
commit: 12203762e6322d7b3f8bfe93c380c1902732a0ba
base: bdb165d693e27ca5066c0d6356562b7cb4a83713
reviewed_at: 2026-11-02T22:45+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 2, nit: 4}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/format/parquet/vparquet_group_reader.cpp:658` — Minor: the
root-cause hunk (the early return after a filter-all predicate batch) has no
test; the six added tests all pass with it reverted, and the two that fail
without the `:238` guard fail by SIGSEGV. Vehicles: a twin of
`parquet_column_chunk_reader_test.cpp:423-456` with `filter_map.init(nullptr,
1, true)`, and the file-driven `parquet_reader_test.cpp` `<filter_all,
enable_lazy>` harness with a page index pruning the trailing pages after an
all-miss page.
- `be/src/format/parquet/vparquet_column_reader.h:238` — Minor: the guard's
second disjunct (`filter_map_data() == nullptr`) also matches a NO-filter
data-less map and silently projects it to all-filtered; `filter_all()` alone
covers every legal data-less map. Unreachable today (the single caller gates on
`has_filter()`), but the function is now a public static. A
`DCHECK(filter_map.has_filter())` precondition closes it.
- Not verified locally: no build or test run; the review is static over the
diff and the in-tree BE sources (format_v2 twin, FilterMap::init, the lazy-read
loop's sibling early returns).
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
