raghav-reglobe commented on PR #69582:
URL: https://github.com/apache/doris/pull/69582#issuecomment-6581915199
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69582
commit: 0ea587b7404c261ca0fec4416c662a15dd7ea6c3
base: 7c049b0befe8aae125ae573d3ed5f27850f89d77
reviewed_at: 2026-11-02T21:37+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 3, nit: 1}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/EagerAggRewriterTest.java:156`
— the new unit test gates the condition literal (fails on the base, passes on
the head) but its branch assertions only require `instanceof SlotReference`,
and no regression case executes a decomposed `If` with data whose comparison
literal equals a branch literal; a data-executed `order_qt_` case in
`query_p0/eager_agg` plus a slot-identity assertion would pin the fix. The
three Minors are this test gap, write-only state left behind
(`aggFunctionsForOutputExpressions`, 3 `funcs.add` calls, a now-unused `Lists`
import) and unreachable null guards; details in the local review documents.
- Not verified locally: no build, unit or regression run — the review is
static over the authoritative diff and the in-tree FE/BE sources (type
coercion, the BE `if` kernel).
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
