github-actions[bot] commented on code in PR #69717:
URL: https://github.com/apache/doris/pull/69717#discussion_r4442228578
##########
be/src/io/cache/block_file_cache_factory.h:
##########
@@ -33,9 +31,10 @@
#include "common/status.h"
#include "io/cache/block_file_cache.h"
#include "io/cache/file_cache_common.h"
-#include "storage/options.h"
namespace doris {
+class CacheBlockPB;
class TUniqueId;
+struct CachePath;
Review Comment:
[P1] Include storage options in the remaining cache callers
Replacing `storage/options.h` with this forward declaration misses callers
that need its definitions.
`be/src/service/http/action/file_cache_action.cpp:191-200` (the `BE_TEST`
reload branch) and `be/src/io/tools/file_cache_microbench.cpp:1163-1174`
construct `std::vector<CachePath>`, read `cache_path.path` and call
`parse_conf_cache_paths`; neither source still reaches `storage/options.h`,
which owns both the complete type and parser declaration. This breaks the
supported non-unity BE unit-test build and the enabled cache microbench.
Include `storage/options.h` directly in both consumers.
##########
be/src/io/fs/s3_file_reader.h:
##########
@@ -25,13 +25,13 @@
#include "io/fs/file_reader.h"
#include "io/fs/file_system.h"
#include "io/fs/path.h"
-#include "io/fs/s3_file_system.h"
#include "util/slice.h"
namespace doris {
class RuntimeProfile;
namespace io {
+class ObjClientHolder;
Review Comment:
[P1] Include the holder definition in the S3 reader test
Removing `s3_file_system.h` from this header leaves
`be/test/io/fs/s3_file_reader_test.cpp` with only an `ObjClientHolder` forward
declaration. Its tests at lines 75, 116 and 163 still construct
`std::make_shared<ObjClientHolder>` and access `holder->_client`, and none of
their remaining includes supplies the definition. That source is part of the
normal `doris_be_test` target, so the BE unit-test build now fails on the
incomplete type. Add a direct `io/fs/s3_file_system.h` include to the test
alongside the production use-site fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
