raghav-reglobe commented on PR #67361:
URL: https://github.com/apache/doris/pull/67361#issuecomment-6585344482
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67361
commit: 717e3a50ac2a52a9909026e4fe9674147cb33198
base: 4bc7f426828e4cedfd2b7ce9b76fe95b14b5b146
reviewed_at: 2026-11-03T00:15+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 3, nit: 4}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/datasource/mvcc/PluginDrivenMvccExternalTable.java:441`
— the two new contracts (one summary WARN per listing with the partial-skip
branch; `getDateTimeLiteral` throwing with its cause) have no test: no FE
fixture mixes a buildable and an un-buildable partition, so the `else if
(skipped > 0)` branch never executes in the suite. One mixed fixture with a log
appender and one `PartitionKeyTest` case would pin both.
- The comments describe the `month(ts)` trigger that master's Iceberg no
longer produces since #68786 (partition value types are carried), so the
surviving triggers are spec-evolution arity, a pinned-schema mismatch and
connectors that pass no value types; and since #69299 the summary fires once
per partition-view cache miss, not per query. Wording only; the code is right.
- Not verified locally: no build or test run; static review over the diff
and the in-tree FE sources.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
