Gabriel39 commented on code in PR #69969:
URL: https://github.com/apache/doris/pull/69969#discussion_r4440708494
##########
be/src/core/data_type_serde/data_type_jsonb_serde.cpp:
##########
@@ -341,14 +341,10 @@ void DataTypeJsonbSerDe::to_string(const IColumn& column,
size_t row_num, Buffer
const auto& col = assert_cast<const ColumnString&,
TypeCheckOnRelease::DISABLE>(column);
const auto& data_ref = col.get_data_at(row_num);
if (data_ref.size > 0) {
- if (_nesting_level > 1) {
- bw.write('"');
- }
+ // JSON text already quotes strings and escapes their contents.
Wrapping a nested
Review Comment:
Fixed in 23d48835e3b. The typed complex reader now passes JSON text through
without trimming its own quotes. Lowercase `null` stays a JSON value, and
uppercase `NULL` is the paired SQL-null marker emitted for nullable JSON
children. ARRAY/MAP/STRUCT round trips now cover both strict modes,
scalar-looking strings, escapes, empty/null containers and null predicates. The
new BE test exercises 66 combinations; all 30 related BE tests and the five
MongoDB suites (138 result checks plus ten expected errors) passed.
##########
docker/thirdparties/docker-compose/mongodb/mongodb.yaml.tpl:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: doris--mongodb
+
+services:
+ mongodb:
+ image: mongo:8.0.20
+ container_name: doris--mongodb
+ ports:
+ - "${MONGODB_PORT:-27017}:27017"
+ environment:
+ MONGO_INITDB_ROOT_USERNAME: mongodb_test
+ MONGO_INITDB_ROOT_PASSWORD: mongodb_test
+ volumes:
+ - ./init:/docker-entrypoint-initdb.d:ro
+ healthcheck:
+ test:
+ - CMD
+ - mongosh
Review Comment:
Fixed in 23d48835e3b. The healthcheck connects through the Compose service
hostname, which reaches the final network-facing server rather than the
loopback-only initialization server. Validated with a test-only initialization
gate: even after the fixture marker exists, the temporary server cannot become
healthy; releasing initialization lets the final server pass the probe.
##########
docker/thirdparties/docker-compose/mongodb/mongodb.yaml.tpl:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: doris--mongodb
+
+services:
+ mongodb:
+ image: mongo:8.0.20
+ container_name: doris--mongodb
+ ports:
+ - "${MONGODB_PORT:-27017}:27017"
+ environment:
+ MONGO_INITDB_ROOT_USERNAME: mongodb_test
+ MONGO_INITDB_ROOT_PASSWORD: mongodb_test
+ volumes:
+ - ./init:/docker-entrypoint-initdb.d:ro
Review Comment:
Fixed in 23d48835e3b. Both image-declared data directories now use bounded
tmpfs mounts, so the disposable fixture creates no anonymous data volumes.
Repeated start/recreate/stop/start checks confirmed the mounts and no
additional Docker volumes. The README describes the lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
