raghav-reglobe commented on PR #69216:
URL: https://github.com/apache/doris/pull/69216#issuecomment-6584038755
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#69216
commit: 3b685f4c7c83187fcc4ab876e22867fe279a20bf
base: f937d950d45313f20864d287df453e1b90f5c615
reviewed_at: 2026-11-02T23:12+05:30
reviewer: raghav-reglobe
model: claude-fable-5-1
effort: xhigh
findings: {blocker: 0, major: 0, minor: 3, nit: 4}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/exprs/function/cast/cast_to_basic_number_common.h:346` — Minor:
`one_rounding` is false for every FLOAT target, so every `CAST(decimal AS
FLOAT)` row formats and parses digits (the body's "fast path is unchanged"
holds for DOUBLE only); a target-aware gate (2^24 / scale ≤ 10 for FLOAT, 2^53
/ scale ≤ 22 for DOUBLE) and a scale-0 early return for ≤ 128-bit natives keep
the result bit-identical. The digit path also allocates a `std::string` per row
where the `char*` overload of `decimal_to_string` at `core/types.h:197` exists.
- `be/src/format/column_type_convert.h:848` and
`be/src/exprs/aggregate/aggregate_function_linear_histogram.h:74` — Minor: the
same `double(unscaled) / double(10^scale)` survives in the file readers'
DECIMAL→FLOAT/DOUBLE schema-evolution conversion and in `linear_histogram`'s
bucket key, so a decimal read through either path can differ from `CAST` by 1
ULP after this change (the PR's own witness 29201.024999999998 lands in bucket
29201025 instead of 29201024). Hosting the helper next to `decimal_to_string`
and calling it at both sites closes it; a follow-up is acceptable if the
description names them.
- Not verified locally: no build or test run; evidence is the diff,
fast_float v3.9.0 sources, OpenJDK 17 BigDecimal and exact-arithmetic
simulations.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
