Gabriel39 commented on code in PR #69672:
URL: https://github.com/apache/doris/pull/69672#discussion_r4450478511
##########
be/src/format/table/es/es_scroll_parser.cpp:
##########
@@ -723,15 +890,24 @@ Status ScrollParser::fill_columns(const
std::vector<SlotDescriptor*>& slots,
}
}
- const rapidjson::Value& col = (*line)[col_name];
Review Comment:
Fixed in ad9d044e97e. Both readers use the corrected shared date decoder.
Source dates now accept short/zero decimal epoch-millis strings, fractional
strings and numeric double tokens; conversion checks numeric bounds and the
civil year before narrowing. Negative fractional instants floor to the
containing second, including formatted docvalue controls. Four-digit
default-format years retain calendar-date semantics.
The new zero-string unit control failed before the fix. The ASAN
parser/reader run now passes 46 tests, with one optional live smoke test
skipped. The new live ES 8.11.3 suite covers both readers, docvalue and
parallel-scroll modes, UTC/+08:00, normalized-sibling source fallback, scalar
arrays, NULLs, local predicates and pure-docvalue projections: all 80 generated
results match an independent internal-table oracle and were rerun without
generation. All seven ES suites pass 1,860 stored checks and 1,764 independent
comparisons, preserving 88 expected planning errors and all existing outputs.
Standard ASAN BE build, clang-format 16, scoped clang-tidy, build hygiene and
glibc compatibility checks passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
