github-actions[bot] commented on code in PR #70007:
URL: https://github.com/apache/doris/pull/70007#discussion_r4450932617
##########
be/src/storage/index/inverted/snii/writer/spimi_term_buffer.cpp:
##########
@@ -375,9 +376,17 @@ void SpimiTermBuffer::report_arena_delta() {
}
// Report reclaimable arena bytes to the process-wide limiter. It may flag
// this buffer for a spill, which the owner thread handles after this call.
- if (global_limiter_ != nullptr) {
Review Comment:
[P1] Re-evaluate global pressure when resident bytes grow without arena
growth. `report_arena_delta()` now calls `GlobalMemoryLimiter::report()` only
when `pool_.arena_bytes() != reported_arena_`. Once a buffer has a floor-sized
arena, pressure can begin from another writer or process memory while new
vocabulary/slot data grows inside the same arena block; the changed tests
already show resident bytes can grow while the arena stays constant. Because
`register_buffer()` does not run a decision, `global_spill_requested_` stays
false and this eligible arena is not spilled until a later block allocation,
which may never occur. Keep the mutex debounce, but run a pressure decision on
resident changes or add a bounded refresh path to avoid missing the
process-wide memory backstop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
