gavinchou commented on PR #67720: URL: https://github.com/apache/doris/pull/67720#issuecomment-6599421692
Please make `_parse_footer()` const as suggested and add a test that repeated footer accesses refresh the LRU order. I'd also like to see the cache-pressure case checked before merging. `VariantExternalMetaReader` can keep a footer alive after eviction, so removing the weak reference may reload the same footer and leave multiple copies alive. Please compare parse counts, query latency and memory with #69811 using a small index-page cache and several VARIANT columns/paths, and check that memory stays accounted for until the last reader releases it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
