liaoxin01 opened a new pull request, #70114:
URL: https://github.com/apache/doris/pull/70114

   ### What problem does this PR solve?
   
   Issue Number: None
   
   Related PR: #69693
   
   Problem Summary:
   
   Backport #69693 to `branch-4.2`.
   
   With packed files enabled, a load using `disable_file_cache=true` could 
still populate the file cache because the packed writer ignored the caller's 
option. Always propagate `FileWriterOptions::write_file_cache` to the packed 
append context.
   
   The test insertion conflict was resolved without importing the unrelated 
nonzero-first-segment feature/test, which is absent on this branch. Includes 
the cache-option unit test and preserves the original accessor cleanup.
   
   ### Release note
   
   Fix packed-file loads with `disable_file_cache=true` unexpectedly populating 
the file cache.
   
   ### Check List (For Author)
   
   - Test: clang-format 16 and `git diff --check` passed. BE unit tests are 
included but were not run locally: the test entry point was blocked by the 
Mac's unaccepted Xcode license. CI `run buildall` is requested separately after 
PR creation.
   - Behavior changed: Yes. Packed writes now honor the caller's file-cache 
setting.
   - Does this need documentation: No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to