github-actions[bot] commented on code in PR #70121:
URL: https://github.com/apache/doris/pull/70121#discussion_r4463243920
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateRoutineLoadInfo.java:
##########
@@ -707,6 +720,10 @@ public void checkJobProperties() throws UserException {
}
}
+ checkCsvControlValue(CsvFileFormatProperties.PROP_ENCLOSE,
Review Comment:
[P2] Exempt metadata replay from the new U+FFFD admission check
An FE running the base version can create a job with `"enclose" = "�"` or
`"escape" = "�"`. On upgrade/restart, `RoutineLoadJob.gsonPostProcess()`
reparses that persisted CREATE statement, calls `setReplay(true)`, and then
reaches these unconditional checks through `validate()`. The exception is
caught as a deserialization failure and the job becomes terminally `CANCELLED`;
even a valid ALTER performed before upgrading cannot avoid it because
`origStmt` still contains the original value. Keep this restriction on new
CREATE/ALTER admission while allowing historical metadata replay, and add a
round-trip case with U+FFFD in the original SQL. This is distinct from the
earlier wrong-byte fallback thread: the newly added validation now cancels an
existing job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
