morningman commented on PR #70130: URL: https://github.com/apache/doris/pull/70130#issuecomment-6623998179
On F-01: both configurations are reachable in the code, but neither is one this suite runs in, and the suggested patch would break the one it runs in outside cloud mode. I am keeping the fixture as it is. - Where the ALTER looks the group up. A job that declares no compute group runs in the one the session was using when it was created, and `SHOW CLUSTERS` marks that one `is_current`; row 0 is only the first by name. Outside cloud mode root has no resource tag, so the lookup goes through `AllBackendComputeGroup` and needs the group in every backend tag. So the fixture holds on a cluster with one compute group in cloud mode, or one backend tag outside it. - That is the topology of both pipelines that run this suite with Kafka: P0 has one BE, tagged `default`, and cloud_p0 has one compute group, `cluster_name0`. The nonConcurrent and external pipelines enable Kafka too, but run only their own groups, and this suite is only in `p0`. At `72e91896bbd` the suite passed in P0 (build 1091160, 30 s) and in cloud_p0 (build 1091162, 26 s). - The fixture is the one `test_routine_load` has used since #49884 (lines 26-37). That suite creates a job with `"workload_group" = "create_routine_load_group"`, and CREATE checks it the same way, as the owner in the job's compute group, so in either configuration you describe `test_routine_load` already fails at that CREATE on master. Hardening only this suite would leave the two fixtures inconsistent; if it is worth doing, it belongs in a change that covers the workload group fixtures together. - The suggested patch would turn P0 red. Outside cloud mode `SHOW CLUSTERS` lists `default`, and `create workload group ... for default ...` does not parse, because `DEFAULT` is a reserved keyword (`extraneous input 'default'`). The name would need backquotes. So I would rate this a Minor about running the suite on a cluster with more than one compute group or resource group, not a Blocker, and leave it out of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
