morningman opened a new pull request, #70209:
URL: https://github.com/apache/doris/pull/70209
### What problem does this PR solve?
Issue Number: None
Related PR: #69392, #69971
Problem Summary:
**In short.** `doris_be_test` does not compile on master since #69971 was
merged, so the BE UT of every PR fails with `BE BUILD FAIL`. This fixes the one
test case that breaks it.
**The problem.** #69392 replaced the `write_path`, `original_write_path` and
`target_path` fields of `IPartitionWriterBase::WriteInfo` with one
`IcebergOutputLocation location`, and updated the callers it knew about.
#69971, merged after it, added
`VParquetWriterTest.HiveAndIcebergParquetPageIndexOptions`, which still sets
the old fields:
```
be/test/format/transformer/vparquet_writer_test.cpp:380:41: error: no
matching constructor for initialization of 'VIcebergPartitionWriter'
```
Each PR built alone, so both were green. TeamCity's BE UT has failed this
way for PRs merged with master `0eb5131db62` (for example build 1092024 of
#69605).
**How this PR fixes it.** The case builds its `WriteInfo` as the other
Iceberg case in the same file does, `.location = IcebergOutputLocation(".",
".")`. Nothing else changes.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
`doris_be_test` builds again with this change, and `VParquetWriterTest`
(16 tests) passes, on a local ASAN build (macOS).
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
