RoanHeNaN opened a new pull request, #70250: URL: https://github.com/apache/doris/pull/70250
## Proposed changes `TabletReader::_filter_delete` is assigned in `_init_delete_condition()` but is **never read** anywhere in the codebase. The actual delete-sign filtering is driven by `_filter_delete_sign` in `BlockReader` / `VerticalBlockReader`, which is derived directly from `_delete_sign_available`: - `be/src/storage/iterator/block_reader.cpp`: `_filter_delete_sign = ... && _delete_sign_available;` - `be/src/storage/iterator/vertical_block_reader.cpp`: `_filter_delete_sign = ... && _delete_sign_available;` `_filter_delete` and its stale comment are leftovers from an earlier refactor and only serve to mislead readers (it looks like it gates deletion, but it does nothing). This PR removes: - the `_filter_delete` field (`tablet_reader.h`) - its assignment (`tablet_reader.cpp`) - the now-unused `cumu_delete` local that only fed it `enable_delete_when_cumu_compaction` is still referenced by the early-return guard at the top of `_init_delete_condition`, so behavior is unchanged. **No functional change.** Verified by grep that `_filter_delete` (word-boundary, excluding `_filter_delete_sign`) and `cumu_delete` have no other references. ## Further comments Pure dead-code removal. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
