JNSimba commented on code in PR #103:
URL:
https://github.com/apache/doris-flink-connector/pull/103#discussion_r1115174036
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/LabelGenerator.java:
##########
@@ -29,6 +29,6 @@ public LabelGenerator(String labelPrefix, boolean enable2PC) {
}
public String generateLabel(long chkId) {
- return enable2PC ? labelPrefix + "_" + chkId : labelPrefix + "_" +
System.currentTimeMillis();
+ return enable2PC ? labelPrefix + "_" + chkId : labelPrefix + "_" +
System.nanoTime() + "_" + Math.random();
Review Comment:
This should also possibly be repeated? What about using the uuid directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
