onex-aranya commented on issue #69928: URL: https://github.com/apache/doris/issues/69928#issuecomment-6654397204
Hi @morningman, thanks for addressing these issues! I noticed that [#70121](https://github.com/apache/doris/pull/70121) and [#70118](https://github.com/apache/doris/pull/70118) have now been merged, covering the issues addressed in my earlier PRs [#69929](https://github.com/apache/doris/pull/69929) and [#69932](https://github.com/apache/doris/pull/69932), respectively. I had raised both PRs on November 1 after investigating and reproducing the issues, along with unit tests and manual verification. For [#69932](https://github.com/apache/doris/pull/69932), I had intentionally limited the initial scope to `send_batch_parallelism` and `load_to_single_tablet`, with plans to address the remaining SHOW CREATE omissions in subsequent PRs. I've reviewed the merged implementations and can see that they cover additional scenarios. However, I wanted to understand whether there were any specific technical limitations or concerns with the approaches in my original PRs, or if these changes were developed independently. I'd appreciate your thoughts on the differences between the implementations and whether there were any particular considerations behind the approach taken. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
