github-actions[bot] commented on code in PR #69995:
URL: https://github.com/apache/doris/pull/69995#discussion_r4482294353
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java:
##########
@@ -58,6 +58,8 @@ public class VariantType extends PrimitiveType {
private final boolean enableVariantDocMode;
private final long variantDocMaterializationMinRows;
private final int variantDocShardCount;
+ private final boolean escapeDotsInKeys;
Review Comment:
[P1] Include escapeDotsInKeys in recursive CTE type equality
`equalsForRecursiveCte` still ignores the new `escapeDotsInKeys` field.
`AnalyzeCTE` uses that method as the anchor/recursive type gate and then emits
the anchor slot type without a cast, so a legacy recursive branch can be
interpreted with escaped key semantics after the CTE (and dotted keys can
resolve incorrectly). Compare this flag or reject the mismatch, and add a
recursive CTE case with a dotted key.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java:
##########
@@ -766,7 +776,8 @@ public Expr visitSearchExpression(SearchExpression
searchExpression,
if (olapTbl != null) {
Column column = slot.getOriginalColumn().orElse(null);
if (column != null) {
Review Comment:
[P2] Encode the translated-slot fallback before index lookup
`getInvertedIndexFromTranslatedSlot` still passes
`slotDesc.getSubColLables()` directly. When the escaped lookup misses or the
slot was remapped through a CTE/projection, this fallback uses logical
`a.b`/`50%` labels instead of the `%2E`/`%25` storage labels and can attach a
legacy or parent index rather than the Variant field-pattern index. Apply the
same root-aware encoding in this fallback and cover a remapped escaped-Variant
SEARCH/MATCH case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
