hubgeter commented on PR #70220:
URL: https://github.com/apache/doris/pull/70220#issuecomment-6650444899
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70220
commit: 431539613dc21f83e330776d146c3345ce471108
base: 380912cc7344e92375c3de58ec37c99602cad013
reviewed_at: 2026-11-05T05:22+00:00
reviewer: hubgeter
model: gpt-6.1-sol
effort: max
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/ColumnDefinition.java:605-606`
— Generic DATETIMEV2 defaults use declared precision. Paimon 2.1 supplied-NULL
default fallback can differ from its former raw-text flooring; ordinary Doris
omitted/DEFAULT writes already rounded. This declared normalization policy is
detailed in the local reports.
-
`regression-test/suites/external_table_p0/iceberg/test_iceberg_add_column_defaults.groovy:193-194`
and
`regression-test/suites/external_table_p0/iceberg/test_iceberg_add_column_defaults.groovy:253-254`
— New physical nested controls copy complete materialized STRUCTs; they do not
establish partial-STRUCT missing-child binding. Nested NULL-literal controls
refuse in FE casts rather than exercising the BE nested-null validator branch.
- `be/src/core/data_type_serde/data_type_timestamptz_serde.cpp:548-551` —
The existing ORC restriction on pre-epoch fractions in [-0.999, 0) seconds
remains; its error directs callers to Parquet. This feature does not widen that
writer value domain.
- This was read-only static review; no reviewer builds, tests or cluster
operations ran. Author evidence covers 93 focused FE tests, a full FE build and
four regression comparisons. The ASAN BE cache has no verified exact-source
build receipt; local native build was ORC-download blocked. Current-head CI
remains separate.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
