Gabriel39 commented on PR #70314:
URL: https://github.com/apache/doris/pull/70314#issuecomment-6677715182
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70314
commit: 7c3c320c7dc0dee5183ef8b32c06a73f248c9086
base: 8442911b266b1a5d01e9cf1f2c932ea778a28b1f
reviewed_at: 2026-11-06T13:27+08:00
reviewer: Gabriel39
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- `be/src/format_v2/parquet/parquet_crypto.cpp:104` — The previous index
allocation and histogram limits are fixed with expected native field sizes,
cumulative bounds, and conservative handling of unknown/skipped containers.
Footer and page-header limits remain unchanged.
- `be/test/format_v2/parquet/parquet_encryption_test.cpp:1488` — Real
encrypted 66,000-bin and 3.03-million-bin histograms, retained hostile-input
tests, and a genuine full-scan reference cover the prior findings. All 18
changed files and complete PR comments were reviewed; no actionable issue
remains.
- This was a read-only review. Author artifacts report 512 selected ASAN
tests: 510 passed and two existing optional benchmark skips. Full FE/BE builds
and SQL were not repeated for these fixes. The separate automated review
workflow stopped on a service usage limit; this receipt does not claim that
workflow passed.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
