This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8e499c0a555 [fix](test) Build vparquet_writer_test against the
location-based Iceberg WriteInfo (#70209)
8e499c0a555 is described below
commit 8e499c0a555d3382f1ca5cbff4e42012e5beab62
Author: Mingyu Chen (Rayner) <[email protected]>
AuthorDate: Wed Nov 4 12:17:57 2026 +0000
[fix](test) Build vparquet_writer_test against the location-based Iceberg
WriteInfo (#70209)
### What problem does this PR solve?
Issue Number: None
Related PR: #69392, #69971
Problem Summary:
**In short.** `doris_be_test` does not compile on master since #69971
was merged, so the BE UT of every PR fails with `BE BUILD FAIL`. This
fixes the one test case that breaks it.
**The problem.** #69392 replaced the `write_path`, `original_write_path`
and `target_path` fields of `IPartitionWriterBase::WriteInfo` with one
`IcebergOutputLocation location`, and updated the callers it knew about.
#69971, merged after it, added
`VParquetWriterTest.HiveAndIcebergParquetPageIndexOptions`, which still
sets the old fields:
```
be/test/format/transformer/vparquet_writer_test.cpp:380:41: error: no
matching constructor for initialization of 'VIcebergPartitionWriter'
```
Each PR built alone, so both were green. TeamCity's BE UT has failed
this way for PRs merged with master `0eb5131db62` (for example build
1092024 of #69605).
**How this PR fixes it.** The case builds its `WriteInfo` as the other
Iceberg case in the same file does, `.location =
IcebergOutputLocation(".", ".")`. Nothing else changes.
---
be/test/format/transformer/vparquet_writer_test.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/be/test/format/transformer/vparquet_writer_test.cpp
b/be/test/format/transformer/vparquet_writer_test.cpp
index 85714050d23..ce07b2650a0 100644
--- a/be/test/format/transformer/vparquet_writer_test.cpp
+++ b/be/test/format/transformer/vparquet_writer_test.cpp
@@ -379,9 +379,7 @@ TEST_F(VParquetWriterTest,
HiveAndIcebergParquetPageIndexOptions) {
if (iceberg_writer) {
VIcebergPartitionWriter writer(sink, {}, exprs, *schema, &json,
{"id", "value", "all_null"},
- {.write_path = ".",
- .original_write_path = ".",
- .target_path = ".",
+ {.location =
IcebergOutputLocation(".", "."),
.file_type =
TFileType::FILE_LOCAL,
.broker_addresses = {}},
name, 0,
TFileFormatType::FORMAT_PARQUET,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
