Gabriel39 commented on code in PR #70246:
URL: https://github.com/apache/doris/pull/70246#discussion_r4477023429
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanRange.java:
##########
@@ -415,6 +417,9 @@ public void populateRangeParams(TTableFormatFileDesc
formatDesc, TFileRangeDesc
return;
}
fileDesc.setFormatVersion(formatVersion);
Review Comment:
Fixed in 4e50cb506e7. Independently encrypted position/equality deletes now
fail with DELETE_READ_UNAVAILABLE before merge-on-read conversion or native
position_deletes range construction. Encrypted delete metadata also prevents
COUNT position-delete netting from bypassing this rejection. The new regression
covers plaintext data with encrypted deletes, both delete kinds, the native
metadata-table path and netted COUNT. The focused FE suite (280 tests) and
Checkstyle passed.
##########
fe/fe-connector/fe-connector-iceberg/src/main/java/org/apache/doris/connector/iceberg/IcebergScanPlanProvider.java:
##########
@@ -1878,6 +1879,7 @@ private IcebergScanRange buildRange(Table table, Schema
scanSchema, DataFile dat
.length(task.length())
.fileSize(dataFile.fileSizeInBytes())
.fileFormat(file.fileFormat)
Review Comment:
Fixed in 4e50cb506e7. Both COUNT algorithms now fall back to per-file ranges
if any live data file carries key metadata, preserving each file's descriptor
and BE guard. The manifest-aggregate path validates all live file metadata
before selecting a representative; this is O(files) with bounded retained heap
and no data-file I/O, since manifest totals cannot certify that later files are
plaintext. Regression coverage exercises both algorithms with the cache
enabled/disabled, while existing plaintext COUNT tests remain green. All 280
focused FE tests and Checkstyle passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
