924060929 commented on code in PR #69806:
URL: https://github.com/apache/doris/pull/69806#discussion_r4438378882
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/PluginDrivenScanNode.java:
##########
@@ -301,6 +312,10 @@ private ConnectorMetadata metadata() {
return m;
}
Review Comment:
Fixed in 109131b84d62. Batch estimation and both whole-scan/partition-batch
getNextBatch callbacks now execute through the node's existing retained
MetadataRead, around the existing TCCL-pinned body. This covers opening
streamSplits and lazy hasNext/next work, not just source construction.
Provider/source ownership, cancellation and close paths remain unchanged. Tests
cover estimation, source opening and lazy iteration in both producer modes,
each with cleanup and same-name recreation controls. Constructor-bypassing
fixtures initialize Optional.empty consistently with real nodes.
Validation: 862 focused unit cases passed across 47 classes; FE build and
Checkstyle passed. Controlled providers, not a live external-service
integration run.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/plugin/PluginDrivenExternalTable.java:
##########
@@ -119,11 +121,24 @@ public PluginDrivenExternalTable(long id, String name,
String remoteName,
*/
public Optional<ConnectorTableHandle> resolveConnectorTableHandle(
Review Comment:
Fixed in 109131b84d62. getNameToPartitionValues now captures the source
observation before handle resolution and uses it for listPartitions. Combined
with the Iceberg listing correction, a confirmed drop reaches guarded cleanup
rather than appearing as an empty partition-values view. Tests exercise the
real partitioned FE schema/listing path and verify that delayed absence cannot
retire a recreated source.
Validation: 862 focused unit cases passed across 47 classes; FE build and
Checkstyle passed. Controlled providers, not a live external-service
integration run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
